Refactor/ruby 33 bump - #365
Merged
Merged
Conversation
mpkorstanje
reviewed
Jul 23, 2026
| rescue StandardError | ||
| nil | ||
| ensure | ||
| Regexp.timeout = previous_timeout |
Member
There was a problem hiding this comment.
I don't think you have to do this. If this is because of the CodeQL warnings, feel free to dismiss them. The regex operates on CiEnvironment.json and environment variables. Both can be trusted in the context of the library.
Contributor
Author
There was a problem hiding this comment.
This bit is because of the bit above. But yes this was a combination of both.
I can remove it if you'd prefer, but given it's not inhibitive I'd rather just get it in.
Member
There was a problem hiding this comment.
Nah. Don't include it. It's is unnecessary complexity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Ruby 3.3 bump + regex handling
⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.